Skip to content

Conversation

dagardner-nv
Copy link
Contributor

@dagardner-nv dagardner-nv commented Sep 30, 2025

Description

  • Add E2E test for text file ingest documentation example
  • Add E2E test for Email Phishing Analyzer
  • Add E2E test for Simple Calc Eval
  • Minor grammatical fix in docs/source/tutorials/create-a-new-workflow.md
  • Remove unused LLMs and eval section from examples/documentation_guides/workflows/text_file_ingest/configs/config.yml
  • Update the run_workflow test helper method to require keyword arguments
  • Update location of configs and data dirs for Email Phishing Analyzer example to match the layout of other examples
  • Move the validate_workflow_output test helper method to be shared by other tests

By Submitting this PR I confirm:

  • I am familiar with the Contributing Guidelines.
  • We require that all contributors "sign-off" on their commits. This certifies that the contribution is your original work, or you have rights to submit it under the same license, or a compatible license.
    • Any contribution which contains commits that are not Signed-Off will not be accepted.
  • When the PR is ready for review, new or existing tests cover these changes.
  • When the PR is ready for review, the documentation is up to date with these changes.

@dagardner-nv dagardner-nv self-assigned this Sep 30, 2025
@dagardner-nv dagardner-nv added improvement Improvement to existing functionality skip-ci Optionally Skip CI for this PR non-breaking Non-breaking change DO NOT MERGE PR should not be merged; see PR for details labels Sep 30, 2025
Copy link

coderabbitai bot commented Sep 30, 2025

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Signed-off-by: David Gardner <[email protected]>
…2e for the optimization run, remove unused imports

Signed-off-by: David Gardner <[email protected]>
Signed-off-by: David Gardner <[email protected]>
Signed-off-by: David Gardner <[email protected]>
…s, add test for simple calculator eval

Signed-off-by: David Gardner <[email protected]>
…to david-more-example-e2e-tests

Signed-off-by: David Gardner <[email protected]>
@dagardner-nv dagardner-nv deleted the branch NVIDIA:release/1.3 October 1, 2025 20:06
@willkill07 willkill07 reopened this Oct 1, 2025
…to david-more-example-e2e-tests

Signed-off-by: David Gardner <[email protected]>
…to david-more-example-e2e-tests

Signed-off-by: David Gardner <[email protected]>
@dagardner-nv dagardner-nv removed skip-ci Optionally Skip CI for this PR DO NOT MERGE PR should not be merged; see PR for details labels Oct 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

improvement Improvement to existing functionality non-breaking Non-breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants